Migration Report by brthor · Pull Request #4310 · dotnet/cli

brthor · 2016-10-04T22:32:08Z

@livarcocc @srivatsn @333fred

/cc @eerhardt @Sridhar-MS @blackdwarf

The migration report including options for outputting to a file or stdout in a user friendly or json format.

Fixes: #4165
Fixes: #4164

Successful Example:

Failure Example:

333fred

Overall looks good to me, thanks for the work @brthor. This unblocks dotnet/project-system#507.

Sign in to view

+using System.Linq;
+namespace Microsoft.DotNet.ProjectJsonMigration
+{
+    public class ProjectMigrationReport


Sign in to view

+
+        public bool AllSucceeded => ! ProjectMigrationReports.Any(p => p.Errors.Any());
+
+        public MigrationReport MergeReport(MigrationReport otherReport)


Sign in to view


+            WriteReport(migrationReport);
+
            return 0;


Sign in to view

+                if (projectMigrationReport.Errors.Any())
+                {
+                    sb.AppendLine($"Project {projectMigrationReport.ProjectName} migration failed ({projectMigrationReport.ProjectDirectory})");
+                    sb.AppendLine(string.Join("\n", projectMigrationReport.Errors.Select(e => e.GetFormattedErrorMessage())));


Sign in to view

+                }
+                else
+                {
+                    sb.AppendLine($"Project {projectMigrationReport.ProjectName} migration succeeded ({projectMigrationReport.ProjectDirectory})");


Sign in to view

+    {
+        public static string GetProjectName(this ProjectContext projectContext)
+        {
+            return Path.GetFileNameWithoutExtension(projectContext.GetOutputPaths("_").CompilationFiles.Assembly);


Sign in to view

+    {
+        public static string GetProjectName(this ProjectContext projectContext)
+        {
+            return Path.GetFileNameWithoutExtension(projectContext.GetOutputPaths("_").CompilationFiles.Assembly);


Sign in to view

+
+        public int SucceededProjectsCount => ProjectMigrationReports.Count(p => !p.Errors.Any());
+
+        public int FailedProjectsCount => ProjectMigrationReports.Count(p => p.Errors.Any());


Sign in to view

+            ProjectDirectory = projectDirectory;
+            ProjectName = projectName;
+            OutputMSBuildProject = outputMSBuildProject;
+            Errors = errors ?? Enumerable.Empty<MigrationError>().ToList();


Sign in to view

+
+        public List<MigrationError> Errors { get; }
+
+        public List<string> Warnings { get; }


eerhardt · 2016-10-05T15:11:54Z

brthor · 2016-10-06T00:44:35Z

Added changes to also tackle https://github.com/dotnet/cli/issues/4164
Addressed all feedback
Please take another pass on Code review.

brthor · 2016-10-06T00:46:44Z

New Samples: (Also writing to stderr/stdout)

brthor · 2016-10-06T03:06:38Z

test Windows_NT x64 Release Build

brthor · 2016-10-06T23:33:52Z

test Windows_NT x64 Release Build

dnfclas added the cla-already-signed label Oct 4, 2016

333fred reviewed Oct 4, 2016

View reviewed changes

eerhardt reviewed Oct 5, 2016

View reviewed changes

Comment thread src/dotnet/commands/dotnet-migrate/MigrateCommand.cs Outdated

WriteReport(migrationReport);

return 0;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

eerhardt reviewed Oct 5, 2016

View reviewed changes

Comment thread src/Microsoft.DotNet.ProjectJsonMigration/Report/ProjectMigrationReport.cs

public List<MigrationError> Errors { get; }

public List<string> Warnings { get; }

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Project Migration Report

fbaf9a6

brthor force-pushed the brthor/migrationreport branch from 7a41f26 to fbaf9a6 Compare October 6, 2016 23:02

brthor merged commit 2727b19 into dotnet:rel/1.0.0 Oct 7, 2016

brthor deleted the brthor/migrationreport branch October 7, 2016 18:01


		public bool AllSucceeded => ! ProjectMigrationReports.Any(p => p.Errors.Any());

		public MigrationReport MergeReport(MigrationReport otherReport)


		public int SucceededProjectsCount => ProjectMigrationReports.Count(p => !p.Errors.Any());

		public int FailedProjectsCount => ProjectMigrationReports.Count(p => p.Errors.Any());


		public List<MigrationError> Errors { get; }

		public List<string> Warnings { get; }

Conversation

brthor commented Oct 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

333fred left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

eerhardt commented Oct 5, 2016

Uh oh!

brthor commented Oct 6, 2016

Uh oh!

brthor commented Oct 6, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brthor commented Oct 6, 2016

Uh oh!

brthor commented Oct 6, 2016

Uh oh!

brthor commented Oct 4, 2016 •

edited

Loading

brthor commented Oct 6, 2016 •

edited

Loading